Skip to content

fix: resolve golangci-lint issues across VDG and CFG packages (PR-02)#601

Merged
shivasurya merged 1 commit intomainfrom
shiva/vdg-querytype-v5-pr02
Mar 12, 2026
Merged

fix: resolve golangci-lint issues across VDG and CFG packages (PR-02)#601
shivasurya merged 1 commit intomainfrom
shiva/vdg-querytype-v5-pr02

Conversation

@shivasurya
Copy link
Owner

@shivasurya shivasurya commented Mar 12, 2026

Part 2/8 of V5 QueryType × VDG Integration. Fix lint issues across VDG and CFG packages post-merge.

@safedep
Copy link

safedep bot commented Mar 12, 2026

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

Copy link
Owner Author

shivasurya commented Mar 12, 2026

Merge activity

  • Mar 12, 4:25 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 12, 4:27 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 12, 4:28 AM UTC: @shivasurya merged this pull request with Graphite.

@shivasurya shivasurya changed the base branch from shiva/vdg-querytype-v5-pr01 to graphite-base/601 March 12, 2026 04:25
@shivasurya shivasurya changed the base branch from graphite-base/601 to main March 12, 2026 04:25
- godot: add periods to all exported function comments
- unconvert: remove unnecessary uint32/string conversions in cfg/builder.go
- unparam: mark unused params with _ or nolint where needed
- unused: add nolint for functions wired in later PRs

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@shivasurya shivasurya force-pushed the shiva/vdg-querytype-v5-pr02 branch from 7c9bce3 to fde2161 Compare March 12, 2026 04:26
@github-actions
Copy link

Code Pathfinder Security Scan

Pass Critical High Medium Low Info

No security issues detected.

Metric Value
Files Scanned 4
Rules 38

Powered by Code Pathfinder

@shivasurya shivasurya merged commit cf87f1b into main Mar 12, 2026
4 of 5 checks passed
@shivasurya shivasurya deleted the shiva/vdg-querytype-v5-pr02 branch March 12, 2026 04:28
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.85%. Comparing base (12839a4) to head (fde2161).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sast-engine/graph/callgraph/cfg/builder.go 60.00% 8 Missing ⚠️
sast-engine/dsl/dataflow_executor.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   83.86%   83.85%   -0.01%     
==========================================
  Files         155      155              
  Lines       20877    20877              
==========================================
- Hits        17509    17507       -2     
- Misses       2728     2729       +1     
- Partials      640      641       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant