fix(ci): fix Go stdlib R2 upload workflow (GOROOT capture + build tag conflict)#559
Merged
shivasurya merged 4 commits intomainfrom Feb 25, 2026
Merged
fix(ci): fix Go stdlib R2 upload workflow (GOROOT capture + build tag conflict)#559shivasurya merged 4 commits intomainfrom
shivasurya merged 4 commits intomainfrom
Conversation
\$GOROOT is not exported to the shell environment by actions/setup-go — only the go binary is added to PATH. Using \`go env GOROOT\` correctly queries the active Go installation's root directory, so all GOROOT_1_XX variables are now captured and the upload script no longer skips every version. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
SafeDep Report SummaryNo dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Code Pathfinder Security ScanNo security issues detected.
Powered by Code Pathfinder |
Adds a push trigger scoped to fix/go-stdlib-r2-goroot-capture so the upload workflow can be validated directly on this branch without needing to merge to main first. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 143 143
Lines 17782 17782
=======================================
Hits 14817 14817
Misses 2426 2426
Partials 539 539 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…dlib conflict Using -tags ignore with go run accidentally satisfies //go:build ignore constraints on Go stdlib generator files (gen_cooked.go, pow10gen.go, etc.), causing 'found packages X and main' and import cycle errors during compilation. Replace the build tag with cpf_generate_stdlib_registry — a project-specific tag that no stdlib file uses — so go run -tags cpf_generate_stdlib_registry compiles only our generator without polluting the stdlib package graph. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Now matches stdlib-r2-upload.yml (Python): only runs on release publish or manual workflow_dispatch, not on branch pushes. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Test plan
🤖 Generated with Claude Code