create new css layout 'resume-simple'#826
Open
Willian1661 wants to merge 2 commits intoshield-wall:masterfrom
Open
create new css layout 'resume-simple'#826Willian1661 wants to merge 2 commits intoshield-wall:masterfrom
Willian1661 wants to merge 2 commits intoshield-wall:masterfrom
Conversation
eerison
requested changes
Apr 30, 2025
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Myprofile resume</title> | ||
| <script type="module" src="src/main.js"></script> | ||
| <link rel="stylesheet" href="src/style/resume-default/main.scss"> |
| @@ -0,0 +1,212 @@ | |||
| @import "bulma/bulma.sass"; | |||
Contributor
Author
There was a problem hiding this comment.
i wanted to use the default style of bulma for the small pieces, paragraphs ; font size, font style; all the small pieces.
| @@ -0,0 +1,212 @@ | |||
| @import "bulma/bulma.sass"; | |||
| @import "../icons"; | |||
Collaborator
There was a problem hiding this comment.
do we need icons in for simple resume?
Contributor
Author
There was a problem hiding this comment.
no if we're following this structure example, at first ,i didn't mean to make it completely identical to this one:
src/style/resume-simple/main.scss
Outdated
| border-bottom: 1px solid $primary-light-color; | ||
| } | ||
|
|
||
| .has-tag { |
src/style/resume-simple/main.scss
Outdated
| } | ||
| } | ||
|
|
||
| .has-tags { |
Collaborator
There was a problem hiding this comment.
it is duplicated! but probably you can remove it :)
src/style/resume-simple/main.scss
Outdated
| } | ||
| } | ||
|
|
||
| .myprofile-block:not(.basic):not(.has-tag):not(.has-tags):not(.has-list):not(.has-timeline) { |
Collaborator
There was a problem hiding this comment.
do you need this css? and the whole css bellow?
Collaborator
|
Hey @Willian1661 i converted this PR to draft, after you finish you put it ready to review again! |
Willian1661
force-pushed
the
resume-simple-layout
branch
from
0ace266 to
3b7a8bc
Compare
Willian1661
force-pushed
the
resume-simple-layout
branch
from
06e02b5 to
19cf3b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.