refactored the module loading and dependency handling#7
Open
KevinAJohnson96 wants to merge 1 commit intoshhossain:mainfrom
Open
refactored the module loading and dependency handling#7KevinAJohnson96 wants to merge 1 commit intoshhossain:mainfrom
KevinAJohnson96 wants to merge 1 commit intoshhossain:mainfrom
Conversation
shhossain
reviewed
Jun 9, 2024
Owner
shhossain
left a comment
shhossain
left a comment
There was a problem hiding this comment.
But if user has both deepface and face_recognation available. Both will be imported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation uses conditional imports within functions controlled by global
variables and locks. This setup may lead to race conditions or other threading issues as threads
may not have real-time knowledge about the imports done by other threads, potentially causing
the same module to be imported multiple times. I improved the FaceDB project by refactoring the module loading and dependency handling to enhance thread safety. I modified the db.py file to handle the deepface and face_recognition imports at the top level and established thread safe checks for their availability.