Fix/mastodon cloud false positive - #3019
Open
goutham-hari wants to merge 2 commits into
Open
Conversation
Contributor
Automatic validation of changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove sites causing false positives
Closes #2977
Problem
Several sites in
data.jsonare configured witherrorType: status_codebut always return HTTP 200 regardless of whether a user account actually exists. This causes Sherlock to falsely report accounts as found on these platforms.Root Cause
Each affected site falls into one of these categories:
mastodon.cloud)SoundCloud,Substack,BabyRu)Fix
Removed all confirmed false-positive sites from
data.json. Each removal was verified by manually testing multiple non-existent usernames and confirming the site returns HTTP 200 in all cases.Sites Removed
mastodon.cloud– domain appears parked/shut down; returns blank page with static image for all URLsBabyRu– returns 200 for non-existent usernamesSoundCloud– response behaviour changed; no longer distinguishes missing profilesSubstack– returns 200 for all username pathsTesting
python sherlock nonexistent_test_user_xyz # Confirmed: removed sites no longer appear in resultsNotes
This PR bundles related false-positive fixes together as a single maintenance update, which is consistent with how similar fixes have been merged in this repo previously.