fix: do not page --list-themes output - #3880
Open
drkemp187 wants to merge 1 commit into
Open
Conversation
When BAT_OPTS (or config) set --paging=always, --list-themes became unusable: the theme list went through the pager one screen at a time and theme names were hard to see. Force paging off for this meta-command so the full theme list always prints to the terminal in one shot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
BAT_OPTS(or the config file) includes--paging=always,bat --list-themesbecame unusable — the theme list was forced through the pager and theme names were hard or impossible to see.Changes
PagingMode::Neverinsidelist_themesso this meta-command always prints the full list in one shotBAT_OPTS=--paging=alwaysstill lists theme names and does not invoke the pagerFixes #1618
Test plan
BAT_OPTS='--paging=always --pager=less' bat --list-themesprints theme names without entering lesslist_themes_*integration tests passlist_themes_ignores_paging_always_from_bat_optspasses