fix: disable paging when listing themes - #3843
Open
Deen3303 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If a user has global paging options configured (for example, via 'BAT_OPTS="--paging=always"' or inside their global configuration file), running 'bat --list-themes' will attempt to pipe the theme list through the pager.
Because of how the theme preview blocks are printed, this forces the pager to display them one by one, rendering the list completely unusable and swallowing the theme header names.
Solution
This PR intercepts the execution flow in 'src/bin/bat/main.rs' right before executing the 'list_themes' command.
Specifically:
This forces 'bat' to print the entire list of themes cleanly to standard output, ignoring any global paging configurations, while leaving normal file-viewing behaviors completely untouched.
Verification
Tested locally by setting:

$env:BAT_OPTS="--paging=always"
.\target\debug\bat.exe --list-themes
(Printed cleanly)