Skip to content

Tests: Add a new user with a specified non-existing primary group#1597

Merged
ikerexxe merged 1 commit intoshadow-maint:masterfrom
aborah-sudo:useradd_1
Mar 24, 2026
Merged

Tests: Add a new user with a specified non-existing primary group#1597
ikerexxe merged 1 commit intoshadow-maint:masterfrom
aborah-sudo:useradd_1

Conversation

@aborah-sudo
Copy link
Copy Markdown
Contributor

This is the transformation to Python of the test located in tests/usertools/01/06_useradd_invalid_named_primary_group.test, which checks that useradd can not add a new user with invalid existing group as primary

This is the transformation to Python of the test located in
`tests/usertools/01/06_useradd_invalid_named_primary_group.test`, which checks that `useradd` can not add a new user with invalid existing group as primary
Copy link
Copy Markdown
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment inline.

By the way, I like the usage of parametrization for this test

@aborah-sudo aborah-sudo requested a review from ikerexxe March 24, 2026 04:52
Copy link
Copy Markdown
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikerexxe ikerexxe merged commit 778b4a4 into shadow-maint:master Mar 24, 2026
16 checks passed
@aborah-sudo aborah-sudo deleted the useradd_1 branch March 25, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants