Add MXFP4 Per Token Group Quant kernel and tests#106
Open
sspintel wants to merge 3 commits intosgl-project:mainfrom
Open
Add MXFP4 Per Token Group Quant kernel and tests#106sspintel wants to merge 3 commits intosgl-project:mainfrom
sspintel wants to merge 3 commits intosgl-project:mainfrom
Conversation
sspintel
force-pushed
the
dev/sp/per_token_group_quant_mxfp4
branch
from
edab1a0 to
e245569
Compare
Remove commented out fp8 blockwise group gemm registration
|
|
||
| batch_size_range = [1, 2, 4, 8, 16, 32, 64] if not IS_CI else [1, 4, 16] | ||
| seq_len_range = [64, 128, 256, 512, 1024, 2048] if not IS_CI else [64, 256] | ||
| group_size_range = [32, 64, 128] |
Collaborator
There was a problem hiding this comment.
do we support >32 grp size for fp4?
Since we have this check isn't it?
assert group_size == 32, f"group_size must be 32 for MXFP4, got {group_size}"
| @@ -0,0 +1,356 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
Collaborator
There was a problem hiding this comment.
add this bench mark test to ci flow in here: .github/workflows/pr-test-xpu.yml
| print("\n" + "=" * 100) | ||
| print("Summary Statistics by Provider") | ||
| print("=" * 100) | ||
| summary = df.groupby("provider").agg( |
Collaborator
There was a problem hiding this comment.
do you have performance numbers? How much memory bandwidth we can achieve with this kernel?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.