chore: add dco check#271
Open
Syspretor wants to merge 1 commit intosgl-project:mainfrom
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pull request template by adding a checklist item for DCO sign-off. Feedback was provided to improve the terminology used for DCO signatures to avoid confusion with GPG signing and to correct the relative link path to the contributing documentation.
| - [ ] Format your code `make fmt`. | ||
| - [ ] Add unit tests or integration tests. | ||
| - [ ] Update the documentation related to the change. | ||
| - [ ] All commits are signed with DCO (`git commit -s`). See [Developer Certificate of Origin (DCO)](CONTRIBUTING.md#developer-certificate-of-origin-dco). |
There was a problem hiding this comment.
There are two minor improvements for this new checklist item:
- Terminology: Use "signed-off" instead of "signed". DCO (Developer Certificate of Origin) specifically uses the
Signed-off-bytrailer (added viagit commit -s), whereas "signed" often implies GPG/SSH signatures (git commit -S). This aligns with the terminology used inCONTRIBUTING.md(e.g., line 104). - Link Path: Since this template is located in the
.github/subdirectory, the relative link toCONTRIBUTING.mdshould be../CONTRIBUTING.mdto ensure it works correctly when viewing the template file directly in the repository browser.
Suggested change
| - [ ] All commits are signed with DCO (`git commit -s`). See [Developer Certificate of Origin (DCO)](CONTRIBUTING.md#developer-certificate-of-origin-dco). | |
| - [ ] All commits are signed-off with DCO (`git commit -s`). See [Developer Certificate of Origin (DCO)](../CONTRIBUTING.md#developer-certificate-of-origin-dco). |
8d2423c to
4d3343d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.