fix(rbg): fix inject env related ut

[Syspretor]

Ⅰ. Motivation

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

• Format your code make fmt.
• Add unit tests or integration tests.
• Update the documentation related to the change.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the unit tests for environment variable injection. It updates the expected environment variables in the TestDefaultInjector_InjectEnv test cases to include RBG_ROLE_INDEX, which is dynamically sourced from Kubernetes pod labels. This ensures the tests accurately validate the injector's functionality.

Highlights

• Test Fix: Updated TestDefaultInjector_InjectEnv to correctly include the RBG_ROLE_INDEX environment variable, ensuring the unit test accurately reflects the injector's behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/discovery/injector_test.go
  • Updated TestDefaultInjector_InjectEnv to include RBG_ROLE_INDEX environment variable in expected injected environment variables.
  • Modified test cases to reflect the dynamic injection of RBG_ROLE_INDEX from metadata.labels['apps.kubernetes.io/pod-index'].

Activity

• No human activity detected on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a unit test for environment variable injection by adding the expectation for the RBG_ROLE_INDEX environment variable. The changes are correct in principle, but I've left a couple of suggestions to improve maintainability by using a defined constant instead of a hardcoded string. This will make the tests more robust to future changes in constant values.

[gemini-code-assist]

To improve maintainability and consistency with the production code, please use the constants.EnvRBGRoleIndex constant instead of the hardcoded string "RBG_ROLE_INDEX".

I also noticed this new environment variable block is duplicated on lines 562-569. You might consider refactoring to a shared variable to avoid this duplication.

Suggested change

	Name: "RBG_ROLE_INDEX",
	Name: constants.EnvRBGRoleIndex,

[gemini-code-assist]

Similar to my other comment, please use the constants.EnvRBGRoleIndex constant here to avoid using a hardcoded string.

Suggested change

	Name: "RBG_ROLE_INDEX",
	Name: constants.EnvRBGRoleIndex,

[cheyang]

/lgtm
/approve