Skip to content

fix(cli): add path traversal protection #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcfre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): add path traversal protection #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/cli/cmd/llm/benchmark/dashboard/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,12 @@ func (s *Server) getExperiment(name string) (*Experiment, error) {
// getResultSummaries returns summaries of all result files in an experiment.
func (s *Server) getResultSummaries(experimentName string) ([]ResultSummary, error) {
expDir := filepath.Join(s.dataDir, experimentName)

// Security check: ensure the path is within dataDir to prevent path traversal
if !s.isPathSafe(expDir) {
return nil, fmt.Errorf("invalid experiment name: path traversal detected")
}

entries, err := os.ReadDir(expDir)
if err != nil {
return nil, err
Expand Down
Loading