fix(pod group): fix instance workload calculation bug#174
fix(pod group): fix instance workload calculation bug#174JasonHe-WQ wants to merge 1 commit intosgl-project:mainfrom
Conversation
Signed-off-by: JasonHe-WQ <[email protected]>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the pod group workload calculation, specifically for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the pod group size calculation for InstanceSet workloads that use a LeaderWorkerSet template. A corresponding unit test has been added to verify the fix, which is great. I have one suggestion to improve the readability of the new calculation logic.
| if role.Workload.String() == LeaderWorkerSetWorkloadType || | ||
| (role.Workload.String() == InstanceSetWorkloadType && role.LeaderWorkerSet != nil) { | ||
| sizePerReplica := int32(1) | ||
| if role.LeaderWorkerSet != nil && role.LeaderWorkerSet.Size != nil && *role.LeaderWorkerSet.Size > 0 { | ||
| sizePerReplica = *role.LeaderWorkerSet.Size | ||
| } | ||
| ret += int(*role.LeaderWorkerSet.Size) * int(*role.Replicas) | ||
| } else { | ||
| ret += int(*role.Replicas) | ||
| ret += int(sizePerReplica * *role.Replicas) | ||
| continue | ||
| } | ||
|
|
||
| ret += int(*role.Replicas) |
There was a problem hiding this comment.
For improved readability and maintainability, consider refactoring this block. Extracting the complex condition into a boolean variable and using a standard if-else structure instead of continue can make the code's intent clearer and easier to follow.
workloadType := role.Workload.String()
useLwsSize := workloadType == LeaderWorkerSetWorkloadType ||
(workloadType == InstanceSetWorkloadType && role.LeaderWorkerSet != nil)
if useLwsSize {
sizePerReplica := int32(1)
if role.LeaderWorkerSet != nil && role.LeaderWorkerSet.Size != nil && *role.LeaderWorkerSet.Size > 0 {
sizePerReplica = *role.LeaderWorkerSet.Size
}
ret += int(sizePerReplica * *role.Replicas)
} else {
ret += int(*role.Replicas)
}1 participant
Ⅰ. Motivation
if xpod group calculation bug
Ⅱ. Modifications
add unit test and add instance workload calculation
Ⅲ. Does this pull request fix one issue?
fixes #172
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.