fix(e2e): Fixed sporadic end-to-end (e2e) failures caused by slow pod…#170
Merged
cheyang merged 10 commits intosgl-project:mainfrom Mar 5, 2026
Merged
fix(e2e): Fixed sporadic end-to-end (e2e) failures caused by slow pod…#170cheyang merged 10 commits intosgl-project:mainfrom
cheyang merged 10 commits intosgl-project:mainfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
4358553 to
6b28f15
Compare
6b28f15 to
475af17
Compare
5d4d933 to
ad3ca38
Compare
ad3ca38 to
c3ddbd0
Compare
67fe91b to
d5e101a
Compare
added 2 commits
March 5, 2026 17:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… processing.
Ⅰ. Motivation
Ⅱ. Modifications
Summary
Fix sporadic e2e test failures and enhance diagnostic capabilities.
Problems Fixed
1. E2E case ConfigMap Not Found
Root Cause: The
ensureDiscoveryConfigModewas called afterconstructAndUpdateRoleStatuses, which populatesrbg.Status.RoleStatuses. This causedshouldUseLegacyDiscoveryConfigto incorrectly detect new RBGs as legacy ones, resulting in ConfigMap not being created before workload creation.Fix: Reorder reconcile steps - move discovery config mode initialization and ConfigMap creation before status construction.
2. Deployment Status Overwritten
Root Cause: When
pod_controllercallssetRestartCondition, it patches the entire status including staleRoleStatusesfrom memory, overwriting the latest values updated byrbg_controller(both use the sameFieldManager="rbg").Fix: Create
toRBGApplyConfigurationForConditionsOnlyto patch only conditions without touchingRoleStatuses.3. Image Pull Timeout in CI
Fix: Pre-load e2e test images into Kind cluster before running tests.
Diagnostic Enhancements
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.