fix(stateful): skip correct unhealth instances

[JasonHe-WQ]

Ⅰ. Motivation

Bug fix

Ⅱ. Modifications

Align with kruise logic

Ⅲ. Does this pull request fix one issue?

#168

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

scale replicas of one random role to 4 and scale its replicas down to one

VI. Special notes for reviews

Checklist

• Format your code make fmt.
• Add unit tests or integration tests.
• Update the documentation related to the change.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the stateful instance set control logic that was causing incorrect handling of unhealthy instances. By reversing a conditional check, the system now accurately identifies and skips unhealthy instances, which is essential for maintaining the stability and desired state of stateful applications. This change ensures proper alignment with established kruise patterns for managing stateful workloads.

Highlights

• Bug Fix: Unhealthy Instance Skipping Logic: Corrected a logical error in the processCondemned function within the stateful instance set control. Previously, the system was configured to skip instances that were isHealthy, which was incorrect. The logic has been inverted to !isHealthy, ensuring that truly unhealthy instances are now correctly identified and skipped during processing, aligning with the intended kruise logic for stateful workloads.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/reconciler/instanceset/statefulmode/stateful_instance_set_control.go
  • Modified the conditional check within the processCondemned function to correctly identify and skip unhealthy instances by changing isHealthy(condemned[i]) to !isHealthy(condemned[i]).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug in the stateful instance set controller's logic for handling condemned instances. The change corrects an inverted condition within the processCondemned function. Previously, in monotonic mode, the controller would incorrectly stop processing when it encountered a healthy instance. With this fix, it now correctly stops for an unhealthy instance that is not the first unhealthy one, which is the intended behavior for ordered operations. The fix is accurate and resolves the issue.

[Syspretor]

/lgtm
/approve