Don't fail build if statsmodels not installable for tests#1321
Closed
tomwhite wants to merge 1 commit intosgkit-dev:mainfrom
Closed
Don't fail build if statsmodels not installable for tests#1321tomwhite wants to merge 1 commit intosgkit-dev:mainfrom
tomwhite wants to merge 1 commit intosgkit-dev:mainfrom
Conversation
Member
tomwhite
commented
Jun 23, 2025
tomwhite
commented
- Fixes Build is failing when importing statsmodels #1319
Member
Author
|
This is failing because the coverage target is not met... |
Member
|
Could try pinning to earlier version of scipy or whatever is breaking things for tests in addition to this, so that we can run the test suite locally but also get coverage reports? Losing test coverage in CI is bad I think |
Member
Author
Agreed - that's what I'm planning to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.