-
Notifications
You must be signed in to change notification settings - Fork 44
📯 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skade
wants to merge
22
commits into
sferik:master
Choose a base branch
from
skade:postbox
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
📯 #13
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7a87c11
Merge pull request #1 from dianakimball/patch-1
sferik 77516d6
:point_up: :point_down:
jin b3798da
Merge pull request #3 from infinitus/master
sferik 7133f95
:round_pushpin:
sferik 95e74b8
:point_left:
dylanjha 266576b
:pizza:
dylanjha 5e78a6d
Merge pull request #7 from dylanjha/master
sferik 32e9d9f
:curry:
amatsuda b14b15a
:u6709::u7121:
amatsuda 6802a8e
Merge pull request #6 from amatsuda/🍛
sferik 8f30081
Merge pull request #4 from amatsuda/🈶🈚️
sferik e02bd21
:100:
sferik b13d869
:up: :rice_scene: :100:
sferik f1b341e
:1234: :walking:
phiggins 3ddbe21
Merge pull request #9 from phiggins/🔢#⃣🚶
sferik a32917e
:book:
tony612 8d6e68d
:lock: :unlock:
tony612 f550c8d
:u7a7a:
tony612 dcd624f
Merge pull request #10 from tony612/add-open-for-io
sferik fd76fbe
Merge pull request #12 from tony612/add-empty-to-array
sferik 6a9ceda
Merge pull request #11 from tony612/add-mutex
sferik f410f35
📯
skade File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,7 @@ class Array | |
| alias 🔁 each | ||
| alias 🍀 sample | ||
| alias 🎰 shuffle | ||
| alias 👈 push | ||
| alias 🍕 slice | ||
| alias 🈳❓ empty? | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,6 @@ class Integer | |
| alias ▶️ next | ||
| alias ◀️ pred | ||
| alias ❌ times | ||
| alias 👆 upto | ||
| alias 👇 downto | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| class IO | ||
| class << self | ||
| alias 📖 open | ||
| end | ||
|
|
||
| alias 🚽 flush | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,5 @@ module Kernel | |
| alias 💻 system | ||
| alias ⚠️ warn | ||
| def 🔟; 10 end | ||
| def 💯; 100 end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| class Mutex | ||
| alias 🔒 lock | ||
| alias 🔓 unlock | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 🔢 = Numeric | ||
|
|
||
| class 🔢 | ||
| alias 🚶 step | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,6 @@ class Object | |
| alias :"#️⃣" hash | ||
| alias 🔬 inspect | ||
| alias 🆔 object_id | ||
| alias ✉️ send | ||
| alias 📬❓ respond_to? | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| class Proc | ||
| alias 📞 call | ||
| alias 🍛 curry | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why GH doesn't display "letter" correctly :(.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem is your web browser. Are you using Chrome?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, Firefox, Chrome is completely broken, Safari does things the right way. Thanks for the hint!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few different options for envelopes and outboxes with arrows pointing in different directions:
📧 📨 📤 📮
Another route would be something a bit more comical. Since
sendis typically used to invokeprivatemethods. I think this one implies “throwing caution to the wind”:💸
Another thing to consider is how/if we want to represent
public_sendversussend. Maybe I’m taking this too seriously but I believe we should think this through before merging. Ideally there would be some interplay between these two representations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go another round and ❤️ the discussion. I haven't picked the symbols just at whim though. I like how 📬 holds the 📧 icon and has a flag indicating that it got mail.
I rarely use
sendto circumventprivate, tbh...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you should use
public_sendto be safe. 😉