Add accessibility identifiers for Saucelabs test stability#140
Merged
Add accessibility identifiers for Saucelabs test stability#140
Conversation
Enables Saucelabs tests to use stable accessibility ID selectors instead of brittle XPath that breaks on view hierarchy changes. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
=============================================
+ Coverage 29.460% 37.518% +8.058%
=============================================
Files 14 14
Lines 1334 1338 +4
Branches 385 385
=============================================
+ Hits 393 502 +109
+ Misses 928 817 -111
- Partials 13 19 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
maxkosty
reviewed
Apr 1, 2026
| let safeName = name ?? "Unknown" | ||
| nameLabel.text = safeName | ||
| accessibilityIdentifier = "ProductCell_\(safeName)" | ||
| addToCartButton.accessibilityIdentifier = "AddToCart_\(safeName)" |
Contributor
There was a problem hiding this comment.
Hm I wonder what the heck is name. I guess I'll just have to find out with Appium Inspector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accessibilityIdentifiertoProductTableViewCell(cell + Add to Cart button) andCartItemCellaccessibility idselectors instead of brittle XPath that breaks on view hierarchy changesTest plan
accessibility idselectors (e.g.AddToCart_Spider Plant,CartItem_Plant Mood)🤖 Generated with Claude Code