Open
Conversation
|
Looks like this did not install them correctly. Lots of: And ultimately did not install the checks into /opt/sensu/embedded/bin/ correctly. See conversation in #293 ZZ |
Contributor
Author
|
@majormoses @zeninfinity I can successfully install these in sensu & binstubs are created as well in embedded sensu ruby. But still it took more time to parse the dependencies of |
Member
|
does this PR superseded #335? |
Contributor
Author
|
@majormoses Yes its superseded for #335, But need your ideas/suggestion on #293 (comment) |
Member
|
Sorry for the long silence, I replied on the PR and am ready to move forward with something as long as we are moving forward and not dropping any features that rely on v3 sdks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
#293
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Known Compatibility Issues