Draft
Conversation
Contributor
wilke0818
commented
Mar 26, 2026
- Create scripts and documentation for generating c2m2 metadata
- Creates metadata based off bundled data (PhysioNet feature data, not raw audio data)
- Creates subject data separately so that metadata about sex and race can be allowed but no links to other data types in order to not allow for connecting diseases to subjects (per DAC/consent agreements)
- Generate links between all other C2M2 types including biosamples (any voice recording), files, and diseases
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a suite of scripts to convert Bridge2AI voice bundle datasets into C2M2-compliant metadata, including tools for processing file metadata, subject demographics, and biosample associations. The reviewer identified a critical issue where only the first feature file was processed and recommended removing the redundant and buggy peds_bundle_to_c2m2.py script. Additional feedback suggests using more idiomatic pathlib methods for file traversal, implementing more specific exception handling, correcting documentation links and formatting, and completing missing ontology mappings for pediatric conditions and parquet file formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.