Skip to content

Conversation

@heinrichschiller
Copy link
Contributor

Hello,

Here are some updates I have made.

Tests show that it should continue to work. I updated PHPUnit, which took some work because I don't know everything. Hopefully, it should be fine.

Best regards,

Heinrich Schiller

@odan
Copy link
Member

odan commented Oct 18, 2025

Thanks @heinrichschiller Please also add php 8.3 and 8.4 to the build.yml file. Thanks.

@heinrichschiller
Copy link
Contributor Author

Sorry. I didn't know that until today and haven't used it.

@heinrichschiller
Copy link
Contributor Author

New attempt. I actually wanted to leave the old PHP versions in and avoid unnecessary changes. Now I've just used the supported PHP versions, see https://www.php.net/supported-versions.php.

I don't know what to do with overtrue/phplint; it already requires at least PHP 8.2. Is that important here? As I understand it, the IDE PHPStorm needs it. I don't use it, for example.

@odan
Copy link
Member

odan commented Nov 6, 2025

There is a small code style issue. To fix it run composer cs:fix

1) src/VideoType.php (operator_linebreak)
      ---------- begin diff ----------
--- /home/runner/work/video-type/video-type/src/VideoType.php
+++ /home/runner/work/video-type/video-type/src/VideoType.php
@@ -68,7 +68,7 @@
      */
     public function equals(VideoType $other): bool
     {
-        return $this->format === $other->format &&
-            $this->mime === $other->mime;
+        return $this->format === $other->format
+            && $this->mime === $other->mime;
     }
 }

      ----------- end diff -----------
      ````

@odan odan merged commit a6ebd13 into selective-php:master Nov 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants