-
Notifications
You must be signed in to change notification settings - Fork 3
Php84 update #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php84 update #37
Conversation
|
Thanks @heinrichschiller Please also add php 8.3 and 8.4 to the build.yml file. Thanks. |
|
Sorry. I didn't know that until today and haven't used it. |
This reverts commit 94611dd.
|
New attempt. I actually wanted to leave the old PHP versions in and avoid unnecessary changes. Now I've just used the supported PHP versions, see https://www.php.net/supported-versions.php. I don't know what to do with overtrue/phplint; it already requires at least PHP 8.2. Is that important here? As I understand it, the IDE PHPStorm needs it. I don't use it, for example. |
|
There is a small code style issue. To fix it run composer cs:fix |
Hello,
Here are some updates I have made.
Tests show that it should continue to work. I updated PHPUnit, which took some work because I don't know everything. Hopefully, it should be fine.
Best regards,
Heinrich Schiller