319 allow get_bulk_asn_whois to return a dictionary#320
Open
petebryan wants to merge 1 commit intosecynic:devfrom
Open
319 allow get_bulk_asn_whois to return a dictionary#320petebryan wants to merge 1 commit intosecynic:devfrom
petebryan wants to merge 1 commit intosecynic:devfrom
Conversation
to return a dictionary of data. Made some changes to reduce code reuse. Added tests and docs. Updated failing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features added:
Added a parameter to allow get_bulk_asn_whois which allows the user to get a dictionary of data instead of the string of data.
Additional changes:
Restructured some of experimental.py in order to reduce code reuse.
Added tests and docs for the new feature change.
Updated some test parameters for tests that were failing locally.
Addresses #319