add infallible serialization functionality#43
Draft
matty-kuhn wants to merge 2 commits into
Draft
Conversation
Author
|
as mentioned here: #help > vest serialization proof strengthening, i'm planning to narrow the scope of this, to strengthening the postconditions on serialize, instead of adding a new function/trait |
Collaborator
|
Thanks for taking the time to do this! The strengthened conditions looks good to me and I agree changing the existing serializer functions would be the easiest path (so no new traits, no duplicate serializing logics, and hopefully relatively small proof changes). |
Author
|
I added some changes to rework so that instead of creating a new trait, i strengthened the post conditions on Combinator. this breaks some of the code in vest-examples, specifically the ones that have custom Combinator implementations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this work was borne out of the discussion here: #41
the bulk of the changes actually lie in
vest/src/infallible.rs, which contains the definitions forsecure_serializeandserialize_infallible. all the other changes in the diff lie in the different codegen for different test files