Pickle - reconstructs the packet from field valies, payload and metadata#4919
Open
guedou wants to merge 1 commit intosecdev:masterfrom
Open
Pickle - reconstructs the packet from field valies, payload and metadata#4919guedou wants to merge 1 commit intosecdev:masterfrom
guedou wants to merge 1 commit intosecdev:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4919 +/- ##
==========================================
- Coverage 80.84% 80.64% -0.20%
==========================================
Files 369 370 +1
Lines 90968 91737 +769
==========================================
+ Hits 73544 73985 +441
- Misses 17424 17752 +328
🚀 New features to boost your workflow:
|
guedou
force-pushed
the
guedou/issue_4599
branch
from
b7adecb to
b9f54f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #4599 but introduces a breaking change as packets used to be built before being pickled. The new code recreates a packet from field values, payload and metadata.