Replace unmaintained JavaScript library for charts with billboard.js#1076
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom Apr 28, 2025
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1075
I quickly reviewed the charting libraries based on d3js that could replace nvd3. In my opinion, the only sane choice was billboard.js.
I tried to minimize the changes, visually and in the PHP code, but 2 visual changes were made on purpose:
The JS code is plain, though a bit more modern: some ES6 features, and no more
var. It should work in any browser from the last decade.