Use more efficient AttributeParentConnectingVisitor#1074
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom Apr 28, 2025
Merged
Use more efficient AttributeParentConnectingVisitor#1074sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom
AttributeParentConnectingVisitor#1074sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom
Conversation
00f7b39 to
5bf9a1b
Compare
c3b51f4 to
c3dbc7f
Compare
AttributeParentConnectingVisitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1:1 copy of php-parsers ParentConnectingVisitor but optimized for our use-case
after PR
before PR
refs #1072 (comment)
Less references between AST nodes mean less work for GC