Update GitHub workflows for rt pull requests#961
Conversation
Explicitly exclude the rt branch from the standard pull_request_target trigger. GitHub has changed its behaviour to using this workflow file instead of the changed workflow file on the rt branch (despite claiming otherwise in the GUI). This is an attempt to prevent that. Signed-off-by: Gerwin Klein <[email protected]>
GitHub has changed its behaviour and seems to be ignoring the contents of the workflow file on the rt branch, using the one on master instead. This is an attempt to provide a workflow file with content that is correct for the rt branch, but store it on the master branch. Signed-off-by: Gerwin Klein <[email protected]>
Xaphiosis
left a comment
There was a problem hiding this comment.
Is there any corresponding github bug report? Any chance they'll fix it?
Also, is it worth having any kind of manual tag / trigger phrase for those stacked PRs?
corlewis
left a comment
There was a problem hiding this comment.
Very annoying that we have to do this.
And yeah, triggering on a naming scheme or a tag would be nice.
I have not found anything. But looking at the status page of GitHub is just horrific in its own right: https://www.githubstatus.com/history -- 19 incidents in February alone and that all just in the first 10 days of Feb.
There is already a manual trigger for both workflow files, so in theory that part should work. |
GitHub Actions has changed its behaviour in how it processes
pull_request_targetPRs to a branch: it now seems to always run the contents of the workflow file from the master branch instead of the target branch. It says otherwise in the GUI when you display the workflow file it claims to run, but it's clearly not what is happening since that workflow file does not even contain the jobs that are being started.The following seems to fix it:
masterthat has content for thertbranch and an explicit branch filter for justrtrtout from the triggers of the standard proof PRrtbranch for consistencyThis does mean that
rtproof checks will run only for PRs to thertbranch, not to branches that themselves branch off thertbranch (e.g. when you stack pull requests), because the branch names need to be listed in the trigger filters.We could think a of a naming scheme for branches that do trigger
rttests. Maybertandrt-*?