Add Crispat Guideassignment#637
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 88.83% 88.48% -0.36%
==========================================
Files 100 101 +1
Lines 7615 7814 +199
==========================================
+ Hits 6765 6914 +149
- Misses 850 900 +50
|
Zethson
approved these changes
May 27, 2026
Member
Zethson
left a comment
There was a problem hiding this comment.
Thank you very much! Awesome stuff.
- Maybe it's just because it's the first time I'm seeing this but I'm confused that there's so many
hasattrchecks for methods to get the (dense & sparse) device arrays to the host in tests. There should be a trivial utility function for this like https://rapids-singlecell.readthedocs.io/en/latest/api/generated/rapids_singlecell.get.X_to_CPU.html - We should also show this off in a tutorial. Could you please also make a PR to the tutorials repository?
- I always like it when there's small runnable examples in the PR description. We're linking to PRs in the changelog so when people look at new features, they should get an improved PR description. Also something your LLM can do if you have
ghset up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we will add Guideassignment to pertpy GPU based on what Crispat does