fix: load raw X when leaving backed mode - #2460
Open
ehsanestaji wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
- Coverage 87.81% 85.87% -1.95%
==========================================
Files 49 49
Lines 7799 7801 +2
==========================================
- Hits 6849 6699 -150
- Misses 950 1102 +152
|
ehsanestaji
force-pushed
the
fix/623-backed-filename-none
branch
from
July 15, 2026 22:58
d16a246 to
ad7d0f2
Compare
ehsanestaji
marked this pull request as ready for review
July 15, 2026 22:58
Author
|
Rebased onto current Local validation:
|
ehsanestaji
force-pushed
the
fix/623-backed-filename-none
branch
from
July 15, 2026 23:03
ad7d0f2 to
b5958cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setting
adata.filename = Noneon a backed object already materializedadata.X, but backed objects read from disk could still loseadata.raw.Xbecauseraw._XstayedNoneafter the backing file was closed.This PR materializes
raw.Xbefore leaving backed mode, adds a regression test for the backed-read path, and includes a release note fragment.Checks
uv run pytest tests/test_backed_hdf5.py::test_return_to_memory_mode_loads_raw_X -quv run pytest tests/test_backed_hdf5.py::test_return_to_memory_mode tests/test_backed_hdf5.py::test_return_to_memory_mode_loads_raw_X tests/test_backed_hdf5.py::test_backed_raw tests/test_raw.py::test_raw_backed -quv run pytest tests/test_raw.py -quv run pytest tests/test_backed_hdf5.py -quv run ruff check src/anndata/_core/file_backing.py tests/test_backed_hdf5.pyuv run ruff format --check src/anndata/_core/file_backing.py tests/test_backed_hdf5.pygit diff --check