Dbus dependency#493
Open
mabong1 wants to merge 5 commits intoscrapinghub:masterfrom
mabong1:dbus-dependency
Open
Dbus dependency#493mabong1 wants to merge 5 commits intoscrapinghub:masterfrom mabong1:dbus-dependency
mabong1 wants to merge 5 commits intoscrapinghub:masterfrom
mabong1:dbus-dependency
Conversation
Current coverage is 86.17% (diff: 100%)@@ master #493 diff @@
==========================================
Files 40 40
Lines 4875 4875
Methods 0 0
Messages 0 0
Branches 677 677
==========================================
Hits 4201 4201
Misses 516 516
Partials 158 158
|
| RUN chmod +x /home/root/startup.sh | ||
|
|
||
| # Start up script (Generate machine UUID) | ||
| ENTRYPOINT ["/home/root/startup.sh"] |
Member
There was a problem hiding this comment.
I think it is not the same as before: previously it was possible to pass command-line arguments to Splash when it is executed from a Docker container (see http://splash.readthedocs.io/en/stable/install.html#passing-custom-options); it looks like you need to handle extra arguments in a script.
Author
There was a problem hiding this comment.
Ok I will look at it and commit again later.
Member
There was a problem hiding this comment.
Thanks! Other than that, the PR looks very clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to issue #491