Update browser_tab.py#426
Update browser_tab.py#426Japan10 wants to merge 16 commits intoscrapinghub:masterfrom Japan10:master
Conversation
Line:915 Change "user-agent" to "User-Agent"
Current coverage is
|
|
Hi @Genius001 thanks for the pull request! There are some test failing because they have "user-agent" instead of "User-Agent" hardcoded in them, would you mind fixing that as well? |
|
Hi, @Youwotma I noticed if change all 'user-agent' to 'User-Agent' in tests/test_execute.py that will cause another problem, And test will failing. The error log https://travis-ci.org/scrapinghub/splash/jobs/118187194#L2146 I could not figure out how to resolve it. But this time I thought whether is it necessary to do this or keep original? If it is necessary, workaround? |
Line: 915
Change "user-agent" to "User-Agent"