changed the opengraph meta data extraction to incorporate the html body.#197
Open
frostrot wants to merge 1 commit intoscrapinghub:masterfrom
Open
changed the opengraph meta data extraction to incorporate the html body.#197frostrot wants to merge 1 commit intoscrapinghub:masterfrom
frostrot wants to merge 1 commit intoscrapinghub:masterfrom
Conversation
lopuhin
reviewed
May 16, 2022
Member
lopuhin
left a comment
lopuhin
left a comment
There was a problem hiding this comment.
Thanks for the PR @frostrot , that's a nice improvement, and thanks for adding tests. Still have a few things left to review. However, would you mind reverting changes unrelated to this PR, such as changing single quotes to double quotes, etc.? This would make it easier to track when and why certain parts of the code were changed.
Member
|
@frostrot also would you mind checking test failures? They look to be related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#192 Added the feature to incorporate all the meta tags outside of the html head, by changing in the function extract_items() in class openClassExtractor. Furthermore, added a test case to named opengraph_test_2 which uses the html of https://www.youtube.com/c/Freecodecamp where the meta tags are also present in the body of the html, and the function is able to correctly identify all the tags and parse it.