-
Notifications
You must be signed in to change notification settings - Fork 25
WJ-1139: add forum schema, prune references, and seed sequences #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4195bd0
WJ-1139: add forum schema, prune references, and seed sequences
Syxless f781696
Update deepwell/migrations/20220906103252_deepwell.sql
Syxless 9ce1887
Update deepwell/migrations/20220906103252_deepwell.sql
Syxless 86612fe
Update deepwell/migrations/20220906103252_deepwell.sql
Syxless d8cdc5d
Update deepwell/migrations/20220906103252_deepwell.sql
Syxless d96a1f0
Merge branch 'develop' into fix/wj-1139-forum-schema
Syxless c731882
WJ-1139: finalize forum schema constraints and compatibility IDs
Syxless File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ use crate::models::message_draft::{self, Entity as MessageDraft}; | |
| use crate::models::message_record::{self, Entity as MessageRecord}; | ||
| use crate::models::page_revision::{self, Entity as PageRevision}; | ||
| use crate::models::text::{self, Entity as Text}; | ||
| use sea_query::Query; | ||
| use sea_query::{Alias, Query}; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct TextService; | ||
|
|
@@ -235,8 +235,15 @@ impl TextService { | |
| .add(not_in_column!( | ||
| MessageRecord, | ||
| message_record::Column::CompiledHash, | ||
| )) | ||
| .add(not_in_column!( | ||
| Alias::new("forum_post_revision"), | ||
| Alias::new("wikitext_hash"), | ||
| )) | ||
| .add(not_in_column!( | ||
| Alias::new("forum_post_revision"), | ||
| Alias::new("compiled_html_hash"), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah I see, temporary measure until new |
||
| )), | ||
| // TODO add forum_post_revision | ||
| ) | ||
| .exec(txn) | ||
| .await | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.