Add support for generic event types#42
Open
Nikaple wants to merge 1 commit intoscottcorgan:masterfrom
Open
Conversation
This PR aims to provide a backward-compatible change on `index.d.ts`, allowing generic event types. Please refer to this [TS playground](https://www.typescriptlang.org/play?#code/KYDwDg9gTgLgBAE2AYwDYEMrDm9BnPOAFQEsA7ATwFEBbEmGYKOAbwFgAoOOCMgCmAA3YGRgAuOHhhRyAcwA0OdKlQAjdMgDWEgGIBXMshgleioyAD8E9JQCUEmAAsSeANyduvZMAHDREqRkyBSUVdS1dAyMTMjMYS2s7B2c3DzhgOhhfEXFJaTlFADpizFk8RIoAbQBdezgnF3cuHgAzFuz-PKCQ5GU1DU0rOH1DY146htSOAF9OThgKMGwAQShZPRocvAAeIgA+OABeOEqiavSQRjIEQkq+YsLS8rhyFqY4AFVbI4ObCnOLJ84BJTudQFcbidBBASAgASdziCzk1OKBILBECgMFgcBgCMRFsAEKRKLR6IwoLsLhDCH8jnA-gd2M1eNsqNSRJDNMAKBAWsQ9h1clQzH1wtpiJUqNU4gkGUl6ikmp5DMA2RzroRubz+fshRIRaF+hFJdLZUM-hMlWkMvR1eDOVqeXyBfq4IaHk8JKt1ptRDsiFLqnsrY00nyWvbLo64NqXXqhDkDaKwgMhoHpaGprMOJxyBSWhpsFQ-DBCMzuC0IBAJHx1FAAvlgt9DgdobC0uoAF61gCOehAEjIG1UTBbbZhCE4ObmHGQvCk6UyFPpZGAAHdiORqMumHxbE152RFwslggyQx3sc15uiITiduLxS2aW8IKD7PbZeoIVeHwAOTdv+ii9j8cC9oUMAQAAyk2sj7rYqK7j+X4AUBigAIyIbmHCnkST5ML+-CAegXbAeBYEQVBsHdAhSHkoRqEkWRmG2EAA) for more info.
Simon-Laux
approved these changes
Apr 13, 2022
Author
|
Thanks for reviewing! Is there any chances that these changes could be released? |
|
I'm just another user xD lets hope @scottcorgan looks at it so code looks good, just wanted to do the same then found your pr, I merged it to a fork of this repo. |
rafaell-lycan
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a backward-compatible change on
index.d.ts, allowing generic event types. Please refer to this TS playground for more info.