Conversation
Move bindings/go/scip/ into its own Go module (github.com/sourcegraph/scip/bindings/go/scip) so consumers of the bindings library don't pull in CLI dependencies like urfave/cli, sqlite, gocloc, etc. - Create bindings/go/scip/go.mod with only the deps needed by the bindings package and its sub-packages (internal/, testutil/, memtest/, speedtest/) - Create go.work at repo root linking root, bindings, and reprolang modules for seamless local development - Add replace directives in root go.mod and reprolang/go.mod to reference the local bindings module - Update flake.nix: speedtest uses modRoot for bindings module, scip CLI uses proxyVendor for replace directive support - Update checks.nix: go-bindings check uses modRoot for bindings module, all Go builds set GOWORK=off (standard nixpkgs pattern) - Update all vendorHash values
Adds a 'packages' job to the Nix workflow that builds scip, speedtest, and proto-generate to catch build failures on PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move bindings/go/scip/ into its own Go module so consumers of the bindings library don't pull in CLI dependencies like urfave/cli, sqlite, gocloc, etc. With this change we also upgrade to Go 1.25.