fix: Catch invalid model specification with duplicate channels, samples and modifiers.#2396
Open
lorenzennio wants to merge 2 commits intoscikit-hep:mainfrom
Open
fix: Catch invalid model specification with duplicate channels, samples and modifiers.#2396lorenzennio wants to merge 2 commits intoscikit-hep:mainfrom
lorenzennio wants to merge 2 commits intoscikit-hep:mainfrom
Conversation
e channels, samples and modifiers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 69 69
Lines 4539 4556 +17
Branches 803 814 +11
=======================================
+ Hits 4461 4478 +17
Misses 45 45
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2059 but extends to channels and samples. We want to catch the case where we have multiple channels with the same name in the model specification, where the first of these would simply be ignored as of now. Similarly, this applies to samples with the same name in a given channel or modifiers with the same name and type in a given sample.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: