Draft
Conversation
henryiii
force-pushed
the
henryiii/feat/force-include
branch
from
31d972b to
39312ce
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
henryiii/feat/force-include
branch
from
39312ce to
e3c1e02
Compare
LecrisUT
reviewed
Feb 26, 2026
| Destination path inside the SDist. | ||
|
|
||
| Leave empty to skip adding this source to the SDist. | ||
| """ |
Collaborator
There was a problem hiding this comment.
Having each item like this just to support writing to either sdist or wheel seems messy for more items that are added. Hatch's format seems better.
We could either flip the order like in hatch and make them force-inclued.(sdist|wheel) each being a dict, or we keep just the one key force-include and if they want to specify differently for sdist or wheel then we have the overrides mechanism that can already do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of force-include, with the help of copilot in VSCode.