Test cases for different use cases of generated files#1193
Test cases for different use cases of generated files#1193henryiii merged 20 commits intoscikit-build:mainfrom
Conversation
|
I'm personally most interested in the use case of being able to open a compiled library with ctypes (7bdec1e), but I figured it was worth trying to explore the edge cases of whatever machinery is in place. |
|
Should we mark.xfail the cases that don't work (to make automation happy) or should we discuss and poke at them a bit first? |
|
Awesome, will try to chevk them out saturday or late today.
Let's first look at the mechanism of how it fails and then we should mark them xfail and revert it in #808. |
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
LGTM overall, just needs a few iterations to clean this up. I did not go through all the test failing cases, but at the first glance, it looks to fail as we are expecting it to fail currently.
tests/packages/cmake_generated/src/cmake_generated/nested1/generated.py.in
Outdated
Show resolved
Hide resolved
|
I'm away for a couple of weeks and didn't manage to connect with anyone on the last two Google meet calls. I'm not sure what the next steps are. Should we get the fixture change merged and then update this branch? We can chat by email if you like. Hope to chat in January. Cheers! |
|
I have beenbin UTC+7 for the last 2 meetings so couldn't join them, but yeah still waiting on a review for the fixture PR. Feel free to rebase on top of those changes though. As for the next steps, best would be is to start looking into #808 designs. There is a reference to But for now, hope you can enjoy your holidays and see you in the next year at the latest. |
A bit of cleanup in preparation for #1193 --------- Signed-off-by: Cristian Le <[email protected]> Signed-off-by: Henry Schreiner <[email protected]> Co-authored-by: Henry Schreiner <[email protected]>
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
Just the xfailing and skipping the inplace editable mode
henryiii
force-pushed
the
eirrgang-editable-test-cases
branch
from
ad04320 to
a0a0ce7
Compare
|
I can't see anything other than "This job failed" for the two failing windows-latest jobs. Help? |
|
Github Actions was broken on Windows for a bit, with random failures. Probably just that, I'll retrigger. |
Support msvc or build environments with default hidden symbols.
henryiii
force-pushed
the
eirrgang-editable-test-cases
branch
from
9252ab8 to
b881e46
Compare
3 participants
Per conference calls, these are some test cases relevant to #808 and #1160.
Use cases for which support is targeted are marked
xfailfor now.We illustrate that, since
inplacemode uses the build tree, we do not expectinplaceeditable mode to work with CMake projects whose build tree layout does not match the source tree layout. In conference calls, we decided that the only first class support would probably be for cases where the CMake install phase actually happens. This support decision warrants clarification, but is deferred to issues like #808. For now (for clarity), the unsupported cases are still in the parameterization matrix, but are annotated withpytest.mark.skip.