packages: Move from our own containerd v1 RPM to containerd.io v2 RPM from docker repo#4821
Open
TeddyAndrieux wants to merge 2 commits intodevelopment/133.0from
Open
Conversation
Contributor
Hello teddyandrieux,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
TeddyAndrieux
force-pushed
the
improvement/mk8s-151-migrate-to-containerd.io
branch
from
4dc4b37 to
c67a534
Compare
Using this config_path patern allow to change the registries configuration without restarting the containerd service
Let's migrate to the official containerd package from docker repository and no longer build and maintain our own containerd package. Due to this change, downgrade is not supported from 133 to 132, it could be possible to handle this case but it would require extra work to downgrade containerd and config before running the downgrade since "old" salt states cannot be used to perform this downgrade since `containerd.io` version we install "obsoletes" the `containerd` version we have in older version. That's why we decided to not support this downgrade path. Fixes: MK8S-151
TeddyAndrieux
force-pushed
the
improvement/mk8s-151-migrate-to-containerd.io
branch
from
c67a534 to
14b2ab5
Compare
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's migrate to the official containerd package from docker repository and no longer build and maintain our own containerd package.
Due to this change, downgrade is not supported from 133 to 132, it could be possible to handle this case but it would require extra work to downgrade containerd and config before running the downgrade since "old" salt states cannot be used to perform this downgrade since
containerd.ioversion we install "obsoletes" thecontainerdversion we have in older version.That's why we decided to not support this downgrade path.
This PR also leverage the usage of
config_pathfor containerd mirrors so that we do not need to restart containerd on registry mirror changesFixes: MK8S-151