feat: add support for scw account project list-resources by remyleone · Pull Request #5640 · scaleway/scaleway-cli

remyleone · 2026-06-04T21:54:09Z

scw account project list-resources -> helpful if you context is a given project and you would like to understand what is inside

codecov-commenter · 2026-06-04T21:56:57Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
2512	2	2510	17

View the top 2 failed test(s) by shortest run time

github.com/scaleway/scaleway-cli/v2/cmd/scw::Test_AllUsage/account_project_list-resources_usage

Stack Traces | 0.01s run time

=== RUN   Test_AllUsage/account_project_list-resources_usage
=== PAUSE Test_AllUsage/account_project_list-resources_usage
=== CONT  Test_AllUsage/account_project_list-resources_usage
    main_test.go:37: 
        	Error Trace:	.../scaleway-cli/core/testing.go:780
        	            				.../scaleway-cli/core/testing.go:693
        	            				.../scaleway-cli/core/testing.go:523
        	Error:      	Not equal: 
        	            	expected: "🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲\n🟩🟩🟩 STDOUT️ 🟩🟩🟩️\nList all resources across all zones and products. Results are grouped by locality and product. Errors are aggregated and not fail-fast.\n\nUSAGE:\n  scw account project list-resources <project-id ...> [arg=value ...]\n\nARGS:\n  project-id=11111111-1111-1111-1111-111111111111   Filter by project ID. If none is passed the default project ID will be used\n  [zones]                                           Filter by zones (comma-separated, e.g. fr-par-1,nl-ams-1). If empty, all zones are queried\n  [products]                                        Filter by products (comma-separated: instances,instance-ips,instance-volumes,instance-snapshots,instance-security-groups,ipam,block-volumes,block-snapshots,buckets,rdb,redis,lb,k8s,containers,functions,flexibleip,secrets,vpc,file,webhosting,registry,searchdb,s2s-vpn-vpn-gateway). If empty, all products are queried\n\nFLAGS:\n  -h, --help                help for list-resources\n      --list-sub-commands   List all subcommands\n\nGLOBAL FLAGS:\n  -c, --config string    The path to the config file\n  -D, --debug            Enable debug mode\n  -o, --output string    Output format: json or human, see 'scw help output' for more info (default \"human\")\n  -p, --profile string   The config profile to use\n"
        	            	actual  : "🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲\n🟩🟩🟩 STDOUT️ 🟩🟩🟩️\nList all resources across all zones and products. Results are grouped by locality and product. Errors are aggregated and not fail-fast.\n\nUSAGE:\n  scw account project list-resources <project-id ...> [arg=value ...]\n\nARGS:\n  project-id=11111111-1111-1111-1111-111111111111   Filter by project ID. If none is passed the default project ID will be used\n  [zones.{index}]                                   Filter by zones (comma-separated, e.g. fr-par-1,nl-ams-1). If empty, all zones are queried\n  [products.{index}]                                Filter by products (comma-separated: instances,instance-ips,instance-volumes,instance-snapshots,instance-security-groups,ipam,block-volumes,block-snapshots,buckets,rdb,redis,lb,k8s,containers,functions,flexibleip,secrets,vpc,file,webhosting,registry,searchdb,s2s-vpn-vpn-gateway). If empty, all products are queried (block-volume | block-snapshot | object-bucket | function-namespace | mongodb-snapshot | cockpit-token | instance-snapshot | ipam-ip | file-filesystem | registry-namespace | s2s-vpn-vpn-gateway | baremetal-server | apple-silicon-server | k8s-cluster | container-namespace | webhosting-hosting | searchdb-deployment | rdb-instance | cockpit-data-source | inference-deployment | instance-server | vpc-gw-ip | mongodb-instance | redis-cluster | fip-ip | vpc-vpc | vpc-gw-gateway | instance-ip | instance-volume | lb-lb | secret-secret | keymanager-key | instance-security-group)\n\nFLAGS:\n  -h, --help                help for list-resources\n      --list-sub-commands   List all subcommands\n\nGLOBAL FLAGS:\n  -c, --config string    The path to the config file\n  -D, --debug            Enable debug mode\n  -o, --output string    Output format: json or human, see 'scw help output' for more info (default \"human\")\n  -p, --profile string   The config profile to use\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -9,4 +9,4 @@
        	            	   project-id=11111111-1111-1111-1111-111111111111   Filter by project ID. If none is passed the default project ID will be used
        	            	-  [zones]                                           Filter by zones (comma-separated, e.g. fr-par-1,nl-ams-1). If empty, all zones are queried
        	            	-  [products]                                        Filter by products (comma-separated: instances,instance-ips,instance-volumes,instance-snapshots,instance-security-groups,ipam,block-volumes,block-snapshots,buckets,rdb,redis,lb,k8s,containers,functions,flexibleip,secrets,vpc,file,webhosting,registry,searchdb,s2s-vpn-vpn-gateway). If empty, all products are queried
        	            	+  [zones.{index}]                                   Filter by zones (comma-separated, e.g. fr-par-1,nl-ams-1). If empty, all zones are queried
        	            	+  [products.{index}]                                Filter by products (comma-separated: instances,instance-ips,instance-volumes,instance-snapshots,instance-security-groups,ipam,block-volumes,block-snapshots,buckets,rdb,redis,lb,k8s,containers,functions,flexibleip,secrets,vpc,file,webhosting,registry,searchdb,s2s-vpn-vpn-gateway). If empty, all products are queried (block-volume | block-snapshot | object-bucket | function-namespace | mongodb-snapshot | cockpit-token | instance-snapshot | ipam-ip | file-filesystem | registry-namespace | s2s-vpn-vpn-gateway | baremetal-server | apple-silicon-server | k8s-cluster | container-namespace | webhosting-hosting | searchdb-deployment | rdb-instance | cockpit-data-source | inference-deployment | instance-server | vpc-gw-ip | mongodb-instance | redis-cluster | fip-ip | vpc-vpc | vpc-gw-gateway | instance-ip | instance-volume | lb-lb | secret-secret | keymanager-key | instance-security-group)
        	            	 
        	Test:       	Test_AllUsage/account_project_list-resources_usage
--- FAIL: Test_AllUsage/account_project_list-resources_usage (0.01s)

github.com/scaleway/scaleway-cli/v2/cmd/scw::Test_AllUsage

Stack Traces | 4.68s run time

=== RUN   Test_AllUsage
--- FAIL: Test_AllUsage (4.68s)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

Copilot

Pull request overview

This PR introduces a new CLI command, scw account project list-resources, intended to list a project’s resources across zones/regions by calling multiple product APIs and aggregating the results into a unified fetch.ResourceResult view.

Changes:

Added account project list-resources command implementation (zone/region de-duplication, concurrency limiting, sorting, and output view).
Introduced a new internal/fetch abstraction plus many per-product “custom fetcher” implementations to list resources per service.
Added documentation and usage golden test fixtures for the new command.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
internal/namespaces/account/v3/custom.go	Registers the new `list-resources` command under `account project`.
internal/namespaces/account/v3/custom_list_resources.go	Implements the new command, including fetcher registry, concurrency, de-duplication, and sorting.
internal/namespaces/account/v3/custom_list_resources_test.go	Adds unit tests for helper functions (query key building, resolvers, sorting).
internal/fetch/fetch.go	Adds generic/non-generic fetcher abstractions, result type, and error-ignoring helper.
internal/namespaces/instance/v1/custom_fetcher.go	Adds instance resource fetchers (servers, IPs, volumes, snapshots).
internal/namespaces/baremetal/v1/custom_fetcher.go	Adds baremetal server fetcher.
internal/namespaces/applesilicon/v1alpha1/custom_fetcher.go	Adds Apple Silicon server fetcher.
internal/namespaces/block/v1alpha1/custom_fetcher.go	Adds block volumes and snapshots fetchers.
internal/namespaces/object/v1/custom_fetcher.go	Adds S3-based bucket listing fetcher for Object Storage.
internal/namespaces/ipam/v1/custom_fetcher.go	Adds IPAM IP listing fetcher.
internal/namespaces/vpc/v2/custom_fetcher.go	Adds VPC listing fetcher.
internal/namespaces/vpcgw/v2/custom_fetcher.go	Adds VPC Gateway and Gateway IPs fetchers.
internal/namespaces/lb/v1/custom_fetcher.go	Adds load balancer listing fetcher.
internal/namespaces/k8s/v1/custom_fetcher.go	Adds Kubernetes cluster listing fetcher.
internal/namespaces/redis/v1/custom_fetcher.go	Adds Redis cluster listing fetcher.
internal/namespaces/rdb/v1/custom_fetcher.go	Adds RDB instance listing fetcher.
internal/namespaces/mongodb/v1alpha1/custom_fetcher.go	Adds MongoDB instance and snapshot listing fetchers.
internal/namespaces/registry/v1/custom_fetcher.go	Adds registry namespace listing fetcher.
internal/namespaces/container/v1/custom_fetcher.go	Adds container namespace listing fetcher.
internal/namespaces/function/v1beta1/custom_fetcher.go	Adds function namespace listing fetcher.
internal/namespaces/secret/v1beta1/custom_fetcher.go	Adds secret listing fetcher.
internal/namespaces/key_manager/v1alpha1/custom_fetcher.go	Adds key manager key listing fetcher.
internal/namespaces/file/v1alpha1/custom_fetcher.go	Adds file system listing fetcher.
internal/namespaces/webhosting/v1/custom_fetcher.go	Adds webhosting hosting listing fetcher.
internal/namespaces/inference/v1/custom_fetcher.go	Adds inference deployment listing fetcher.
internal/namespaces/cockpit/v1/custom_fetcher.go	Adds cockpit token and datasource listing fetchers.
internal/namespaces/flexibleip/v1alpha1/custom_fetcher.go	Adds flexible IP listing fetcher.
internal/namespaces/searchdb/v1alpha1/custom_fetcher.go	Adds SearchDB deployment listing fetcher.
docs/commands/account.md	Documents the new `account project list-resources` command.
cmd/scw/testdata/test-all-usage-account-project-usage.golden	Updates `account project` usage listing to include `list-resources`.
cmd/scw/testdata/test-all-usage-account-project-list-resources-usage.golden	Adds the usage golden file for `account project list-resources`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

estellesoulard · 2026-07-23T09:57:00Z

+	"registry-namespaces":  fetch.WrapFetcher(&registry.FetchNamespaces{}),
+	"searchdb-deployments": fetch.WrapFetcher(&searchdb.FetchDeployments{}),
+	"s2s-vpn-vpn-gateway":  fetch.WrapFetcher(&s2s_vpn.FetchVpnGateways{}),
+}


Homogenize namings ? Some are plural, some singular, some match exactly product-resource but some do not (ie key-manager vs keymanager-key or rather keymanager-keys if we keep all plurals)

estellesoulard · 2026-07-23T10:00:08Z

+				Name:       "products",
+				Short:      `Filter by products (comma-separated: instances,instance-ips,instance-volumes,instance-snapshots,ipam,block-volumes,block-snapshots,buckets,rdb,redis,lb,k8s,containers,functions,flexibleip,secrets,vpc,file,webhosting,registry,searchdb,s2s-vpn-vpn-gateway). If empty, all products are queried`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,


Currently accepts any value. Add validation if products is present?

estellesoulard · 2026-07-23T10:03:53Z

+|------|---|-------------|
+| project-id | Default: `` | Filter by project ID. If none is passed the default project ID will be used |
+| zones |  | Filter by zones (comma-separated, e.g. fr-par-1,nl-ams-1). If empty, all zones are queried |
+| products |  | Filter by products (comma-separated: instances,instance-ips,instance-volumes,instance-snapshots,ipam,block-volumes,block-snapshots,buckets,rdb,redis,lb,k8s,containers,functions,flexibleip,secrets,vpc,file,webhosting,registry,searchdb,s2s-vpn-vpn-gateway). If empty, all products are queried |


This currently contains a mix of product names, resource names and non valid values

Semantically, the filter seems to apply on resources and not products (ie a valid filter is ipam-ip and not ipam as a whole). Should there be an actual product filter ? Should this filter be renamed to resources?

estellesoulard · 2026-07-23T10:08:46Z

+
+type FetchServers struct{}
+
+func (s *FetchServers) Resource() string {


Why (func (s *Fetch...) Resource() string { instead of func (s Fetch...) Resource() string { like in most other namespaces ?

estellesoulard · 2026-07-23T10:08:55Z

+
+type FetchServers struct{}
+
+func (s *FetchServers) Resource() string {


Why (func (s *Fetch...) Resource() string { instead of func (s Fetch...) Resource() string { like in most other namespaces ?

estellesoulard · 2026-07-23T10:09:29Z

+
+type FetchSnapshots struct{}
+
+func (s *FetchSnapshots) Resource() string {


Why (func (s *Fetch...) Resource() string { instead of func (s Fetch...) Resource() string { like in most other namespaces ?

estellesoulard · 2026-07-23T10:25:00Z

+//
+// This map is needed because some products have different naming between
+// their CLI namespace and their ProductFetchers key (e.g., "baremetal" -> "baremetal-servers").
+func getNamespaceToProductMap() map[string]string {


Can we add an e2e test that iterates on each entry, and filters on one product at a time to make the CLI calls, verifying that no API error occurs ? This would ensure that all product names are correct.

estellesoulard · 2026-07-23T10:32:23Z

+	// Create S3 client for use in the resources command.
+	s3Client := newS3ClientForResources(client, region)
+	if s3Client == nil {
+		return nil, nil


Not sure if this is a me issue, but scw account project list-resources products.0=object-buckets seems to always exit here without making any API call.

remyleone changed the title ~~feat: add support for scw resources list~~ feat: add support for scw account project list-resources Jun 11, 2026

github-actions Bot added the account Account issues, bugs and feature requests label Jun 11, 2026

remyleone marked this pull request as ready for review July 2, 2026 15:45

remyleone requested a review from a team as a code owner July 2, 2026 15:45

Copilot AI review requested due to automatic review settings July 2, 2026 15:45

remyleone requested review from a team as code owners July 2, 2026 15:45

Copilot started reviewing on behalf of remyleone July 2, 2026 15:52 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

remyleone force-pushed the resources branch 2 times, most recently from 3a39735 to 9493767 Compare July 3, 2026 08:46

feat: add support for scw account project list-resources

6761fd4

remyleone force-pushed the resources branch from 9493767 to 6761fd4 Compare July 23, 2026 08:30

Fix

b0bebe9

estellesoulard reviewed Jul 23, 2026

View reviewed changes

remyleone commented Jul 24, 2026

View reviewed changes

Comment thread internal/namespaces/account/v3/custom_list_resources.go Outdated

remyleone added 4 commits July 24, 2026 17:46

Add support for security group in instance

891c7d3

Fix

8c8a2fe

Fix

d611685

Fix

49b26fd

remyleone marked this pull request as draft July 27, 2026 15:51


		type FetchServers struct{}

		func (s *FetchServers) Resource() string {


		type FetchSnapshots struct{}

		func (s *FetchSnapshots) Resource() string {

Uh oh!

Conversation

remyleone commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

estellesoulard Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

estellesoulard Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

estellesoulard Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estellesoulard Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estellesoulard Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estellesoulard Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estellesoulard Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

estellesoulard Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

remyleone commented Jun 4, 2026 •

edited

Loading

codecov-commenter commented Jun 4, 2026 •

edited

Loading

estellesoulard Jul 23, 2026 •

edited

Loading

estellesoulard Jul 23, 2026 •

edited

Loading

estellesoulard Jul 23, 2026 •

edited

Loading

estellesoulard Jul 23, 2026 •

edited

Loading

estellesoulard Jul 23, 2026 •

edited

Loading