Skip to content

fix(cli): add local_development.redis_enabled manifest opt-out (MAY-1086) #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IdkwhatImD0ing wants to merge 4 commits into
base: next
Choose a base branch
from
Open

fix(cli): add local_development.redis_enabled manifest opt-out (MAY-1086) #365

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7817ced
chore(deps): relax redis pin to support 6.x/7.x (#363)
smoreinis May 22, 2026
f10b378
fix(cli): add local_development.redis_enabled manifest opt-out (MAY-1…
IdkwhatImD0ing May 25, 2026
f41703c
fix(cli): plug parent-env REDIS_URL leak and add coverage (MAY-1086)
IdkwhatImD0ing May 25, 2026
760328a
test(cli): decouple run_handlers tests from tutorial path
IdkwhatImD0ing May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies = [
"jsonref>=1.1.0,<2",
"temporalio>=1.26.0,<2",
"aiohttp>=3.10.10,<4",
"redis>=5.2.0,<6",
"redis>=5.2.0,<8",
"litellm>=1.83.7,<2",
"kubernetes>=25.0.0,<36.0.0",
"jinja2>=3.1.3,<4",
Expand Down
21 changes: 19 additions & 2 deletions requirements-dev.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,13 @@ frozenlist==1.8.0
# via aiosignal
fsspec==2026.3.0
# via huggingface-hub
genai-prices==0.0.61
# via pydantic-ai-slim
google-auth==2.49.1
# via kubernetes
griffelib==2.0.2
# via openai-agents
# via pydantic-ai-slim
h11==0.16.0
# via httpcore
# via uvicorn
Expand All @@ -126,12 +129,15 @@ httpcore==1.0.9
httpx==0.28.1
# via agentex-sdk
# via anthropic
# via genai-prices
# via httpx-aiohttp
# via huggingface-hub
# via langsmith
# via litellm
# via mcp
# via openai
# via pydantic-ai-slim
# via pydantic-graph
# via respx
# via scale-gp
# via scale-gp-beta
Expand Down Expand Up @@ -196,6 +202,8 @@ langsmith==0.7.22
# via langchain-core
litellm==1.83.7
# via agentex-sdk
logfire-api==4.33.0
# via pydantic-graph
markdown-it-py==3.0.0
# via rich
markupsafe==3.0.3
Expand Down Expand Up @@ -236,6 +244,7 @@ opentelemetry-api==1.40.0
# via ddtrace
# via opentelemetry-sdk
# via opentelemetry-semantic-conventions
# via pydantic-ai-slim
opentelemetry-sdk==1.40.0
# via agentex-sdk
opentelemetry-semantic-conventions==0.61b0
Expand Down Expand Up @@ -287,18 +296,25 @@ pydantic==2.12.5
# via agentex-sdk
# via anthropic
# via fastapi
# via genai-prices
# via langchain-core
# via langsmith
# via litellm
# via mcp
# via openai
# via openai-agents
# via pydantic-ai-slim
# via pydantic-graph
# via pydantic-settings
# via python-on-whales
# via scale-gp
# via scale-gp-beta
pydantic-ai-slim==1.101.0
# via agentex-sdk
pydantic-core==2.41.5
# via pydantic
pydantic-graph==1.101.0
# via pydantic-ai-slim
pydantic-settings==2.13.1
# via mcp
pygments==2.19.2
Expand All @@ -308,7 +324,6 @@ pygments==2.19.2
# via rich
pyjwt==2.12.1
# via mcp
# via redis
pyright==1.1.399
pytest==8.4.2
# via agentex-sdk
Expand Down Expand Up @@ -339,7 +354,7 @@ pyzmq==27.1.0
# via jupyter-client
questionary==2.1.1
# via agentex-sdk
redis==5.3.1
redis==7.4.0
# via agentex-sdk
referencing==0.37.0
# via jsonschema
Expand Down Expand Up @@ -459,6 +474,8 @@ typing-inspection==0.4.2
# via fastapi
# via mcp
# via pydantic
# via pydantic-ai-slim
# via pydantic-graph
# via pydantic-settings
tzdata==2025.3
# via agentex-sdk
Expand Down
21 changes: 19 additions & 2 deletions requirements.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,13 @@ frozenlist==1.8.0
# via aiosignal
fsspec==2026.3.0
# via huggingface-hub
genai-prices==0.0.61
# via pydantic-ai-slim
google-auth==2.49.1
# via kubernetes
griffelib==2.0.2
# via openai-agents
# via pydantic-ai-slim
h11==0.16.0
# via httpcore
# via uvicorn
Expand All @@ -113,12 +116,15 @@ httpcore==1.0.9
httpx==0.28.1
# via agentex-sdk
# via anthropic
# via genai-prices
# via httpx-aiohttp
# via huggingface-hub
# via langsmith
# via litellm
# via mcp
# via openai
# via pydantic-ai-slim
# via pydantic-graph
# via scale-gp
# via scale-gp-beta
httpx-aiohttp==0.1.12
Expand Down Expand Up @@ -180,6 +186,8 @@ langsmith==0.7.22
# via langchain-core
litellm==1.83.7
# via agentex-sdk
logfire-api==4.33.0
# via pydantic-graph
markdown-it-py==4.0.0
# via rich
markupsafe==3.0.3
Expand Down Expand Up @@ -214,6 +222,7 @@ opentelemetry-api==1.40.0
# via ddtrace
# via opentelemetry-sdk
# via opentelemetry-semantic-conventions
# via pydantic-ai-slim
opentelemetry-sdk==1.40.0
# via agentex-sdk
opentelemetry-semantic-conventions==0.61b0
Expand Down Expand Up @@ -260,18 +269,25 @@ pydantic==2.12.5
# via agentex-sdk
# via anthropic
# via fastapi
# via genai-prices
# via langchain-core
# via langsmith
# via litellm
# via mcp
# via openai
# via openai-agents
# via pydantic-ai-slim
# via pydantic-graph
# via pydantic-settings
# via python-on-whales
# via scale-gp
# via scale-gp-beta
pydantic-ai-slim==1.101.0
# via agentex-sdk
pydantic-core==2.41.5
# via pydantic
pydantic-graph==1.101.0
# via pydantic-ai-slim
pydantic-settings==2.13.1
# via mcp
pygments==2.20.0
Expand All @@ -281,7 +297,6 @@ pygments==2.20.0
# via rich
pyjwt==2.12.1
# via mcp
# via redis
pytest==9.0.2
# via agentex-sdk
# via pytest-asyncio
Expand All @@ -308,7 +323,7 @@ pyzmq==27.1.0
# via jupyter-client
questionary==2.1.1
# via agentex-sdk
redis==5.3.1
redis==7.4.0
# via agentex-sdk
referencing==0.37.0
# via jsonschema
Expand Down Expand Up @@ -424,6 +439,8 @@ typing-inspection==0.4.2
# via fastapi
# via mcp
# via pydantic
# via pydantic-ai-slim
# via pydantic-graph
# via pydantic-settings
tzdata==2025.3
# via agentex-sdk
Expand Down
8 changes: 7 additions & 1 deletion src/agentex/lib/cli/handlers/run_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,13 +365,19 @@ def create_agent_environment(manifest: AgentManifest) -> dict[str, str]:
env_vars = {
"ENVIRONMENT": "development",
"TEMPORAL_ADDRESS": "localhost:7233",
"REDIS_URL": "redis://localhost:6379",
"AGENT_NAME": manifest.agent.name,
"ACP_TYPE": manifest.agent.acp_type,
"ACP_URL": f"http://{manifest.local_development.agent.host_address}", # type: ignore[union-attr]
"ACP_PORT": str(manifest.local_development.agent.port), # type: ignore[union-attr]
}

# Gate the default REDIS_URL on an explicit manifest flag. Agents that don't use
# adk.messages/adk.streaming can set local_development.redis_enabled: false to avoid
# the localhost:6379 default, which otherwise causes silent request hangs when no
# local Redis is reachable (MAY-1086).
if manifest.local_development is None or manifest.local_development.redis_enabled:
env_vars["REDIS_URL"] = "redis://localhost:6379"
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated

if manifest.agent.agent_input_type:
env_vars["AGENT_INPUT_TYPE"] = manifest.agent.agent_input_type

Expand Down
9 changes: 9 additions & 0 deletions src/agentex/lib/sdk/config/local_development_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,12 @@ class LocalDevelopmentConfig(BaseModel):
paths: LocalPathsConfig | None = Field(
default=None, description="File paths for local development"
)
redis_enabled: bool = Field(
default=True,
description=(
"Whether the local CLI should set REDIS_URL=redis://localhost:6379 for the "
"agent process. Set to false for agents that don't use adk.messages/adk.streaming "
"when no local Redis is available, to avoid silent request hangs from the lazy "
"Redis client."
),
)
Loading