snmp-exporter: Add hsmPartitionSerialNumber and hsmPartitionLabel to …#11165
Open
rajivmucheli wants to merge 2 commits intomasterfrom
Open
snmp-exporter: Add hsmPartitionSerialNumber and hsmPartitionLabel to …#11165rajivmucheli wants to merge 2 commits intomasterfrom
rajivmucheli wants to merge 2 commits intomasterfrom
Conversation
…all Thales metrics
This change ensures consistent labeling across all snmp_thales_* metrics by adding
hsmPartitionSerialNumber and hsmPartitionLabel labels.
Changes:
1. _snmp-exporter-thales.yaml:
- Added hsmPartitionSerialNumber as an index to all HSM-level metrics
- Added hsmPartitionLabel as a lookup (resolved from hsmSerialNumber + hsmPartitionSerialNumber)
- Affected metrics (20 HSM-level metrics):
* snmp_thales_hsmSerialNumber
* snmp_thales_hsmFirmwareVersion
* snmp_thales_hsmLabel
* snmp_thales_hsmModel
* snmp_thales_hsmAuthenticationMethod
* snmp_thales_hsmRpvInitialized
* snmp_thales_hsmFipsMode
* snmp_thales_hsmPerformance
* snmp_thales_hsmStorageTotalBytes
* snmp_thales_hsmStorageAllocatedBytes
* snmp_thales_hsmStorageAvailableBytes
tRo e
peconfig hales.y lin peconfig hales.y w peconfig hales.y lin me ure)
also have the hsmPartitionSerialNumber label for consistent querying
Background:
Previously, only partition-level metrics had hsmPartitionSerialNumber and hsmPartitionPreviously, only partition-level mesmPreviously, only partition SystPreviously, only partition-leelatePreviously, only partition-level ionLabePreviously, only partition-level metrics hricRelabelings).
This change enables consistent Prometheus queries across all Thales metrics using
both hsmPartitionSerialNumber and hsmPartitionLabel labels.
rajivmucheli
requested review from
Kuckkuck,
joluc,
m-kratochvil,
swagner-de and
timojohlo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…all Thales metrics
This change ensures consistent labeling across all snmp_thales_* metrics by adding hsmPartitionSerialNumber and hsmPartitionLabel labels.
Changes:
tRo e
peconfig hales.y lin peconfig hales.y w peconfig hales.y lin me ure)
also have the hsmPartitionSerialNumber label for consistent querying
Background:
Previously, only partition-level metrics had hsmPartitionSerialNumber and hsmPartitionPreviously, only partition-level mesmPreviously, only partition SystPreviously, only partition-leelatePreviously, only partition-level ionLabePreviously, only partition-level metrics hricRelabelings).
This change enables consistent Prometheus queries across all Thales metrics using both hsmPartitionSerialNumber and hsmPartitionLabel labels.