Skip to content

update for sort-dropdown to address accessiblity issues.#7296

Open
trmccormick wants to merge 4 commits intomainfrom
feature/sort-label-i18n-fix
Open

update for sort-dropdown to address accessiblity issues.#7296
trmccormick wants to merge 4 commits intomainfrom
feature/sort-label-i18n-fix

Conversation

@trmccormick
Copy link
Contributor

Fixes

Fixes #7235 ; refs #7235

Summary

Improve accessibility and localization of sort dropdowns in the search interface.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Sort dropdowns now use descriptive, internationalized labels instead of icons.
  • All sort options are clearly labeled and accessible to screen readers.
  • Sort labels are consistent across all supported locales.
  • No runtime errors occur when rendering sort fields.

Type of change (for release notes)

notes-bugfix Bug Fixes

Detailed Description

This PR updates the sort dropdowns in the search interface to enhance accessibility and localization:

  • Replaces triangle icons with text labels for sort options.
  • Uses i18n translation keys for all sort labels.
  • Ensures translation keys are present in all major locale files.
  • Fixes runtime error caused by lambda usage in Blacklight sort configuration.

Changes proposed in this pull request:

  • Update sort field configuration to use direct i18n string lookups.
  • Add missing translation keys for sort labels to all major locale files.
  • Remove lambda usage from sort label configuration to resolve runtime error.

@samvera/hyrax-code-reviewers

@trmccormick trmccormick requested a review from nhomenda December 3, 2025 23:02
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test Results

    13 files  ±0      13 suites  ±0   2h 47m 54s ⏱️ - 5m 2s
 7 014 tests ±0   6 707 ✅  - 1  306 💤 ±0  1 ❌ +1 
18 683 runs  ±0  18 179 ✅  - 3  501 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit c7ec65d. ± Comparison against base commit 8410736.

This pull request removes 367 and adds 367 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3449cc9398>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f565bbbb2d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa666ad99e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f344eb91b88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f565b977940>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa666b3f150>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: cc0b0b06-f4a3-44c1-88b2-23b5d064f5e7
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 12c92ba3-d1d4-433a-9f75-04004d7a542c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: e72e1845-ad60-4ff9-b576-98a6d55c3d70
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 618082b1-4563-4f64-a46b-957b475e9606
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1bea4ce890>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5574439100>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f678e5b61a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1be9a46558>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f55744a7bc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f678e5a1a48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 3bf05d38-3fcf-41b5-b274-f749d59c1e8f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0ae88f68-d9b4-46a6-b034-ddb238979936
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 64c30f10-4e25-4496-a6e5-7aa3ff41eddc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 9f5cf988-9907-4729-bbc3-82fed90e8ce6
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public catalog view sort-dropdown options need accessible labels for screen readers

1 participant