Skip to content

Conversation

@randalldfloyd
Copy link
Contributor

@randalldfloyd randalldfloyd commented Oct 7, 2025

#7214

This draft PR is a starting point for Rails 8 support. It has gemspec overrides to use core component branches that allow Rails 8. All of the test apps build and run successfully at Rails 8 with those overrides and a handful of initial fixes.

Currently, the gemspec uses a named branch (rails-8) in core components; this was done so that the test apps will build/run, which will enable specs to be worked on in parallel with core component updates.

Core components are currently awaiting releases so that the aforementioned overrides can be undone. So full Rails 8 compatibility should be possible by merging/releasing in the following in order:

samvera/hydra-head#564
samvera/hydra-head#565
samvera/hydra-derivatives#266
samvera/hydra-derivatives#267
samvera/hydra-works#399
samvera/hydra-editor#227

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Test Results

    13 files  ±0      13 suites  ±0   2h 40m 34s ⏱️ - 12m 44s
 6 954 tests ±0   6 545 ✅  - 103  306 💤 ±0  103 ❌ +103 
18 504 runs  ±0  17 894 ✅  - 109  501 💤 ±0  109 ❌ +109 

For more details on these failures, see this check.

Results for commit 0eca704. ± Comparison against base commit 2f4eb6f.

This pull request removes 360 and adds 360 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0b9c7d8d50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3c61790140>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff08df40788>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0b9cb9fc90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3c5df2e748>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff086c48988>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 6815b5fe-87b1-403c-ac4b-41b5410abcc0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2edd8b4d-8d1a-46fc-a2fa-81933322c354
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 72152b09-8681-4506-8e0c-a008f42520cf
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a86c093a-496c-464a-8bb3-fb023d3d8b43
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2d9273fde0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7ed7c33ea0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb27e658848>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2d93a535d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7ed839ba58>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb27a872588>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 0007ce56-6ed1-4e86-a49f-5aa9d5f31ef8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4b077665-4f36-4a38-b56d-96eb11854e3e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 5d46c430-bbec-47a7-9422-3e06f31dcaeb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: db2f0625-49cc-4912-9291-59ed6de84f3a
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant