feat: Create anchor target type plugin for xhtml#844
feat: Create anchor target type plugin for xhtml#844jtoloui-ibm wants to merge 5 commits intosamclarke:masterfrom
Conversation
|
I was struggling to assign an icon to replace the |
|
Hey @samclarke, please let me know if this format is okay as a plugin |
|
Hey @samclarke, hope you're doing well. Was just wondering if this PR is okay for the next minor version for a plugin. |
samclarke
left a comment
There was a problem hiding this comment.
Thanks for the PR. It looks good! Sorry for the delay in reviewing it.
Could you revert the package-lock.json file to the master branch version? The default behaviour of npm install annoyingly rewrites (have to use npm ci to avoid that).
| attr(node, 'target', target); | ||
| } | ||
|
|
||
| if (target === '_self' || |
There was a problem hiding this comment.
It might be worth adding a check to see if this plugin is loaded as we probably don't want to allow other targets if it isn't.
There isn't a way to check from here as the converters don't have access to have but could check for if this plugin exists:
if (sceditor.plugins.anchortarget ...
|
Any update on it ? And it's possible to add it too in bbcode? |
Add support for target type in anchor tag xhtml
To support target type in xhtml links