Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR contains two bug fixes: correcting the root directory path resolution in the website component and fixing the API usage for LLM schema generation with the Gemini model.
- Fixed incorrect starting directory level in
getLocalSourceFilepath resolution logic - Normalized the resolved path using
path.resolve()for consistency - Corrected
typia.llm.schemaAPI call to include required$defsparameter for Gemini model
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
website/src/components/internal/getLocalSourceFile.ts |
Fixed root directory resolution by starting one level higher and using path.resolve() to normalize the final path |
examples/src/llm/schema-recursive-gemini.ts |
Corrected API usage by adding empty $defs parameter to typia.llm.schema call for Gemini model |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the handling of file paths and dependency management in the codebase. The main changes focus on refining the way the project root directory is determined, ensuring consistent path resolution, and updating the usage of a schema generation function.
Path handling and root directory resolution:
getLocalSourceFile.tsby adjusting the starting point ofcwdfrom__dirname/..to__dirname/../.., ensuring more accurate traversal to the true project root.path.resolve(cwd), guaranteeing that the returned path is always absolute and normalized.pathmodule to support the new path resolution logic.Schema function usage:
typia.llm.schema<IDepartment, "gemini">()by passing an empty object as an argument, likely to align with updated API requirements or to ensure explicit configuration.