fix(lint): nolint modernize on backward loop in it.Reverse#895
Merged
samber merged 3 commits intoMay 23, 2026
Conversation
slices.Backward requires Go 1.24+ but lo supports Go 1.18+.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 32 32
Lines 5082 5082
=======================================
Hits 4706 4706
Misses 273 273
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also add cross-references from Uniq and UniqBy similarHelpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modernize linter (golangci-lint v2.12+) flags the backward loop in it.Reverse as replaceable with slices.Backward.
However, slices.Backward was introduced in Go 1.24, and lo supports Go 1.18+. This adds a targeted nolint directive with an explanation.