Open
Conversation
Allow users to provide a direct access to the shar under share["backend"]["path"] This can be used to set up a test by performing operations directly on the underlying filesystem before the test is run over SMB. Signed-off-by: Sachin Prabhu <sp@spui.uk>
Some tests may require additional information to run their tests, we can provide this information in the extra section. Signed-off-by: Sachin Prabhu <sp@spui.uk>
Signed-off-by: Sachin Prabhu <sp@spui.uk>
spuiuk
force-pushed
the
supplementary_tests
branch
from
0e67bf0 to
d24ea4d
Compare
Collaborator
|
Isn't #63 also related? |
Collaborator
Author
yes, This PR replaces #63. I was waiting for the tests to complete before updating that PR. I will be closing PR #63 in favour of this one. There has been several changes in the rest of the code which means a big rewrite for supplementary tests were needed. This PR is a result of these changes. |
Collaborator
Author
|
Note that the new tests are not run yet in the CI system as we need the sit-environment to set it up for us. So not putting it up for review yet and will work on enabling the tests for sit-environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a supplementary group test.
This test is to check writes to a folder owned by a supplementary group.
Requirements:
user["extra"]["supplementary_group"]
Steps:
group set to sgroup and mode 0770
To allow us to run this test, we need to
a) Allow direct access to the underlying filesystem - Through the share->backend->path conf config option.
b) Allow us to pass an extra configuration option through the extra->supplementary_group conf option.