fix: show HAL+JSON responses correctly in Telescope#85
Open
emanueljacob wants to merge 1 commit into
Open
Conversation
Responses with content types like application/hal+json were stored as "HTML Response" because only application/json was decoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Telescope entries for Saloon client requests only decode bodies when the content type contains
application/json.APIs that return
application/hal+json(or other+jsontypes) never match that check. The body stays a string, andsanitizeResponseBody()falls through toHTML Response, so the real payload is missing in Telescope.What changed
+jsoncontent types (for exampleapplication/hal+json,application/vnd.api+json) as JSON informatBody()sanitizeResponseBody()the same way Telescope'sClientRequestWatcherdoes, even when the content type is not exactapplication/jsonhal+json, charset variants, JSON:API, redaction, and the HTML negative caseHTML and other non-JSON bodies still show as
HTML Response.