feat: add package trust link deny command - #1279
Conversation
Let a Verified PBO decline a pending Public Secure trust request by request ID or authoring org ID.
jshackell-sfdc
left a comment
jshackell-sfdc
left a comment
There was a problem hiding this comment.
Please see my questions.
| @@ -0,0 +1,29 @@ | |||
| # summary | |||
|
|
|||
| Approve a Public Secure trust link request. | |||
There was a problem hiding this comment.
Do customers know what a Public Secure trust link request is? Add a brief blurb about it if not.
|
|
||
| # description | ||
|
|
||
| Run this command against a verified packaging org (PBO) to accept a pending VerifiedDev trust request from an authoring org. Identify the request with either --request or --authoring-org. |
There was a problem hiding this comment.
Is a pending VerifiedDev trust request the same thing as a Public Secure trust link request?
If so, can you keep to one term? And explain what it is all is?
| @@ -0,0 +1,31 @@ | |||
| # summary | |||
|
|
|||
| Deny a Public Secure trust link request. | |||
There was a problem hiding this comment.
Same comments as the approve command above.
There was a problem hiding this comment.
I noticed you have a number of PRs around these same commands. So same comments for those PRs too.
There was a problem hiding this comment.
@jshackell-sfdc We're going to do a CLI doc/text review after all the PRs are merged into our team's branch. I'll note your comments for review at that time. Thanks!
… t/packaging-distribution/link-deny
2 participants
Summary
sf package trust link denyfor verified PBO admins--request <2vt...>or--authoring-org <00D...>and delegate toPackageTrustLink.denyStatus = Declined); JSON schema and command snapshot coverageLibrary: forcedotcom/packaging#922. Plugin CI needs that library on npm (next
5.0.9-spi.*after packaging#921 /5.0.9-spi.4) before the pin can be bumped the way approve used5.0.9-spi.4.Also stacks on plugin-packaging#1277 (approve command). Extra approve commits drop out once that PR merges.
Test plan
yarn mocha test/commands/package/packageTrustLinkDeny.test.ts@salesforce/packagingto the published SPI build that includesdeny